Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r167288382
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java ---
    @@ -362,6 +362,8 @@ public static void addSystemStreams(StormTopology 
topology) {
         public static void addEventLogger(Map<String, Object> conf, 
StormTopology topology) {
             Integer numExecutors = 
ObjectReader.getInt(conf.get(Config.TOPOLOGY_EVENTLOGGER_EXECUTORS),
                     ObjectReader.getInt(conf.get(Config.TOPOLOGY_WORKERS)));
    +        if(numExecutors==null || numExecutors==0)
    --- End diff --
    
    nit can we fix the style here with a space after the if and '{' '}'


---

Reply via email to