Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2566#discussion_r170298520
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -1505,35 +1508,36 @@ public static StormTopology 
addVersions(StormTopology topology) {
             Map<String, Object> defaultsConf = null;
             Map<String, Object> stormConf = null;
             for (String part: cp) {
    -            File f = new File(part);
    -            if (f.isDirectory()) {
    -                if (defaultsConf == null) {
    -                    defaultsConf = readConfIgnoreNotFound(yaml, new 
File(f, "defaults.yaml"));
    -                }
    -                
    -                if (stormConf == null) {
    -                    stormConf = readConfIgnoreNotFound(yaml, new File(f, 
"storm.yaml"));
    +            String wildcardSuffix = File.separator + "*";
    --- End diff --
    
    Wouldn't it also work to just check if the part ends with "*"? 


---

Reply via email to