Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r173212518
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -44,6 +44,16 @@
Assignment assignmentInfo(String stormId, Runnable callback);
+ Assignment remoteAssignmentInfo(String stormId, Runnable callback);
--- End diff --
nit: could we get javadocs for the new methods? I know we don't have them
for any of the others, but I think it would help long term to know what they
APIs are for and which daemon is supposed to call them. This is especially
true for the case of stormId, which translates a topology name to a topology
id, even though getTopoId already does the same thing? It would be nice to
know why that is the case.
---
