GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2590
Advertising
STORM-2974: Add transactional non-opaque spout to storm-kafka-client
https://issues.apache.org/jira/browse/STORM-2974
The changes outside the Trident package are because I'd like us to start
using
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
for testing instead of our own mockito mocks. In order to do that we have to
refer to the Consumer interface instead of KafkaConsumer. The replacement is a
breaking change in a few places. I'm not expecting this to go on 1.x, and
backward compatibility was already broken in
https://github.com/apache/storm/pull/2300, so I haven't done any work to
provide a smooth transition.
I've tried to follow the transactional spout in storm-kafka to implement
this as much as possible.
There are a couple of followup tasks for this that I'll try to get done
later, namely https://issues.apache.org/jira/browse/STORM-2990 and
https://issues.apache.org/jira/browse/STORM-2991.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2974
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2590
----
commit b0294fef3696a8fa3a70e79ce5f54f79d1b86ef0
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-03-09T19:57:53Z
STORM-2974: Add transactional spout to storm-kafka-client
----
---
