Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2588#discussion_r173631476
  
    --- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java
 ---
    @@ -31,116 +30,131 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    -import java.util.Map;
    -import java.util.concurrent.ExecutionException;
    -
    -import java.util.Map;
    -import java.util.concurrent.ExecutionException;
    +import com.microsoft.azure.eventhubs.EventData;
    +import com.microsoft.azure.eventhubs.EventHubClient;
    +import com.microsoft.azure.eventhubs.PartitionSender;
    +import com.microsoft.azure.eventhubs.EventHubException;
     
     /**
      * A bolt that writes event message to EventHub.
    + * <p>
    + * <p>
    + * The implementation has two modes of operation:
    + * <ul>
    + * <li>partitionmode = true, One bolt for per partition write.</li>
    --- End diff --
    
    Nit: This seems like an enum would be a good fit.


---

Reply via email to