Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2588#discussion_r173635700
  
    --- Diff: 
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/format/IEventDataScheme.java
 ---
    @@ -15,30 +15,32 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      
*******************************************************************************/
    -package org.apache.storm.eventhubs.spout;
    -
    -import com.microsoft.azure.eventhubs.EventData;
    -import org.apache.storm.tuple.Fields;
    +package org.apache.storm.eventhubs.format;
     
     import java.io.Serializable;
     import java.util.List;
     
    +import org.apache.storm.eventhubs.core.EventHubMessage;
    +import org.apache.storm.tuple.Fields;
    +
    +/**
    + * Data scheme to use when deserializing bytes read from eventhub.
    + */
     public interface IEventDataScheme extends Serializable {
     
    -  /**
    -   * Deserialize an AMQP Message into a Tuple.
    -   *
    -   * @see #getOutputFields() for the list of fields the tuple will contain.
    -   *
    -   * @param eventData The EventData to Deserialize.
    -   * @return A tuple containing the deserialized fields of the message.
    -   */
    -  List<Object> deserialize(EventData eventData);
    +    /**
    +     * Deserialize read EventHub Message into a Tuple.
    +     *
    +     * @param eventHubMessage The EventHubMessage to be deserialized.
    +     * @return A list of Objects representing the deserialized the message.
    --- End diff --
    
    Nit: The last "the" is unnecessary


---

Reply via email to