Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/459#discussion_r175268334
--- Diff: external/storm-kafka/pom.xml ---
@@ -57,7 +57,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
- <maxAllowedViolations>557</maxAllowedViolations>
+ <maxAllowedViolations>561</maxAllowedViolations>
--- End diff --
What we did with checkstyle, for better or worse, was agree on a set of
rules and then apply those rules. We didn't go through and fix every checkstyle
violation when we did that. However, we agreed that any pull requests should
not increase the number of alerts, and preferably decrease them. It would be
better if you could reformat any new 80+character lines to please the
checkstyle monster.
---
