[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2587#discussion_r175576651
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java ---
    @@ -54,25 +54,17 @@ public PacemakerClientPool(Map<String, Object> config) {
             }
         }
         
    -    public HBMessage send(HBMessage m) throws PacemakerConnectionException 
{
    -        try {
    +    public HBMessage send(HBMessage m) throws InterruptedException {
                 return getWriteClient().send(m);
    -        } catch (Exception e) {
    -            rotateClients();
    --- End diff --
    
    Thanks, that makes sense. rotateClients looks unused now, does it make 
sense to keep?


---