Github user revans2 commented on the issue:
    Great catch I forgot to update the normal has Map/HashMap to a 
ConcurrentHashMap.  Yes the guarantees of ConcurrentMap allow for retry and we 
do have side effects in some of the computes.
    I will update the comments as well to say what requirements we have for the 
type.  The computeIfAbsent methods have no side effects, so we don't need to 
worry about them as much.  I'll see if I can come up with a way to make it so 
we don't need as strong of a guarantee for `compute` so perhaps we could use 
other implementations.


Reply via email to