Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2624#discussion_r180053408
--- Diff:
storm-server/src/main/java/org/apache/storm/nimbus/DefaultTopologyValidator.java
---
@@ -15,19 +15,53 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.storm.nimbus;
+import java.util.Map;
+import org.apache.storm.generated.Bolt;
import org.apache.storm.generated.InvalidTopologyException;
+import org.apache.storm.generated.SpoutSpec;
import org.apache.storm.generated.StormTopology;
-import java.util.Map;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class DefaultTopologyValidator implements ITopologyValidator {
+ private static final Logger LOG =
LoggerFactory.getLogger(DefaultTopologyValidator.class);
@Override
- public void prepare(Map<String, Object> StormConf){
+ public void prepare(Map stormConf){
--- End diff --
Please keep exposing generic type if possible.
---
