Github user HeartSaVioR commented on a diff in the pull request:
    --- Diff: 
    @@ -15,19 +15,53 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
     package org.apache.storm.nimbus;
    +import java.util.Map;
    +import org.apache.storm.generated.Bolt;
     import org.apache.storm.generated.InvalidTopologyException;
    +import org.apache.storm.generated.SpoutSpec;
     import org.apache.storm.generated.StormTopology;
    -import java.util.Map;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     public class DefaultTopologyValidator implements ITopologyValidator {
    +    private static final Logger LOG = 
    -    public void prepare(Map<String, Object> StormConf){
    +    public void prepare(Map stormConf){
    --- End diff --
    Please keep exposing generic type if possible.


Reply via email to