[GitHub] storm pull request #2631: [STORM-3025] Optimize Cluster methods with Caching...

[agresch]

Github user agresch commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2631#discussion_r180794169
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceRequest.java
 ---
    @@ -187,4 +187,29 @@ public double getTotalCpu() {
         public NormalizedResources getNormalizedResources() {
             return this.normalizedResources;
         }
    +
    +    public void removeOffHeap(final double offHeap) {
    +        this.offHeap += offHeap;
    +    }
    +
    +    public void remove(WorkerResources value) {
    --- End diff --
    
    were these used?


---