Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2634#discussion_r182758538
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
    @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map<String, 
Object> topologyConf, final
         }
     
         private void setupBackPressureCheckTimer(final Map<String, Object> 
topologyConf) {
    -        final Integer workerCount = 
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_WORKERS));
    -        if (workerCount <= 1) {
    +        Set<Integer> nonLocalTasks = 
Sets.difference(workerState.getTaskToComponent().keySet(),
    --- End diff --
    
    
https://github.com/apache/storm/blob/master/examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java#L109
 This is fine because the code also gets the num of workers from topologyInfo.
    
    
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java#L363-L364
 this is also fine because we override the default value of 
`TOPOLOGY_EVENTLOGGER_EXECUTORS` when we submit the topology if it's on RAS.
    Similar to 
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java#L276
    
    



---

Reply via email to