[GitHub] storm pull request #2638: [STORM-3034] Adding exception stacktrace for execu...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2638#discussion_r182844665
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -361,6 +363,7 @@ public void run() {
                                 Time.sleep(s);
                         }
                     } catch (Throwable t) {
    +                    LOG.info("Async loop Exception Stacktrace is: {} ", 
getStackTrace(t));
    --- End diff --
    
    Thanks. Wouldn't it make sense to add the throwable to the log statement 
there then, so both L370 and 372 print the exception? (I'm asking why we want a 
separate log for this stack trace)


---