Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2659#discussion_r185929379
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
    @@ -293,7 +295,7 @@ public Double getTotalMemReqTask(ExecutorDetails exec) {
          * Gets the total memory resource list for a set of tasks that is part 
of a topology.
          *
          * @param executors all executors for a topology
    -     * @return Map<ExecutorDetails   ,       Double> , a map of the total 
memory requirement for all tasks in topology topoId.
    +     * @return Map<ExecutorDetails>  a map of the total memory requirement 
for all tasks in topology topoId.
    --- End diff --
    
    Looks not right to me. `@return Set<SharedMemory>` ?


---

Reply via email to