actually, hit sent too fast, the PR is addressing fix for 1.2.2, I know this thread is for 1.2 but do you want a patch for 2.x branch as well?
On Mon, May 7, 2018 at 5:39 PM, Artem Ervits <[email protected]> wrote: > Taylor, patch is up https://github.com/apache/storm/pull/2665, please > include the PR in the 1.2.2. > > On Mon, May 7, 2018 at 4:41 PM, P. Taylor Goetz <[email protected]> wrote: > >> The build for 1.2.2-rc3 finished just as this arrived in my inbox. ;) >> >> I’m happy to include a fix and rebuild the rc. But I won’t have time to >> put together a pull request today. It’s an easy fix that can be copied from >> one of the other reporters. >> >> I’ll hold off on starting the rc3 until we come up with a decision. >> >> -Taylor >> >> > On May 7, 2018, at 4:18 PM, Priyank Shah <[email protected]> wrote: >> > >> > Is it possible to include https://issues.apache.org/jira >> /browse/STORM-2988 in 1.2.2 release? Seems like a legit bug and a quick >> fix. >> > >> > On 5/7/18, 8:45 AM, "P. Taylor Goetz" <[email protected]> wrote: >> > >> > Canceling in order to include STORM-3059 in this release. >> > >> > -Taylor >> > >> >> On May 3, 2018, at 11:42 AM, P. Taylor Goetz <[email protected]> >> wrote: >> >> >> >> This is a call to vote on releasing Apache Storm 1.2.2 (rc2) >> >> >> >> Full list of changes in this release: >> >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. >> 2.2-rc2/RELEASE_NOTES.html >> >> >> >> The tag/commit to be voted upon is v1.2.2: >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h >> =7cb19fb3befa65e5ff9e5e02f38e16de865982a9;hb=e001672cf0ea59f >> e6989b563fb6bbb450fe8e7e5 >> >> >> >> The source archive being voted upon can be found here: >> >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. >> 2.2-rc2/apache-storm-1.2.2-src.tar.gz >> >> >> >> Other release files, signatures and digests can be found here: >> >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.2-rc2/ >> >> >> >> The release artifacts are signed with the following key: >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_p >> lain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> >> >> >> The Nexus staging repository for this release is: >> >> >> >> https://repository.apache.org/content/repositories/orgapachestorm-1062 >> >> >> >> Please vote on releasing this package as Apache Storm 1.2.2. >> >> >> >> When voting, please list the actions taken to verify the release. >> >> >> >> This vote will be open for 72 hours or until at least 3 PMC members >> vote +1. >> >> >> >> [ ] +1 Release this package as Apache Storm 1.2.2 >> >> [ ] 0 No opinion >> >> [ ] -1 Do not release this package because... >> >> >> >> Thanks to everyone who contributed to this release. >> >> >> >> -Taylor >> > >> > >> > >> >> >
