Github user dbist commented on a diff in the pull request:
https://github.com/apache/storm/pull/2665#discussion_r186566699
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java ---
@@ -67,7 +68,7 @@ public void prepare(MetricRegistry metricsRegistry,
Map<String, Object> stormCon
}
public static String getMetricsJMXDomain(Map reporterConf) {
- return Utils.getString(reporterConf, JMX_DOMAIN);
+ return
Utils.getString(reporterConf.get(Config.STORM_DAEMON_METRICS_REPORTER_PLUGIN_DOMAIN),
null);
--- End diff --
happy to oblige, would like to draw a consensus as in branch 2.x I can't
just import Config class, be it due to moving of the class from store-core to
storm-client or something else? It's explicitly looking for the key in the
Config class?
---
