GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2685

    STORM-1294: Port netty-unit-test to Java

    https://issues.apache.org/jira/browse/STORM-1294
    
    The batch-test was not being run, and wouldn't pass with the given 
configuration. It was disabled in this PR 
https://github.com/apache/storm/pull/847/files#diff-d183c4c873554507040b705bf17624b8.
 Since no one mentioned it, it looks like it might just have been a mistake. 
Updating the configuration to match the one used in the other tests makes the 
test pass, so I think we might as well include it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-1294

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2685
    
----
commit d4ebac9c3b7d5ef58f8860780058f590a2d4e107
Author: Stig Rohde Døssing <srdo@...>
Date:   2018-05-20T19:50:18Z

    STORM-1294: Port netty-unit-test to Java

----


---

Reply via email to