Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2687#discussion_r190067973
  
    --- Diff: storm-client/src/genthrift.sh ---
    @@ -17,7 +17,7 @@
     
     rm -rf gen-javabean gen-py py
     rm -rf jvm/org/apache/storm/generated
    -thrift --gen java:beans,hashcode,nocamel,generated_annotations=undated 
--gen py:utf8strings storm.thrift
    --- End diff --
    
    Not sure why we had hashcode to begin with. From the 0.9.3 compiler --help 
it shows
    ```
      csharp (C#):
    ...
        hashcode:        Generate a hashcode and equals implementation for 
classes.
    ```
    
    So it is generating hash codes for the c# language.  I believe that it was 
also being used for python, but that is not documented in thrift.  In 0.11.0 it 
is still there in the help command for c#, but now if I run with out the change 
I get the error.
    
    ```
    [FAILURE:generation:1] Error: unknown option java:hashcode
    ```
     


---

Reply via email to