[GitHub] storm issue #2718: STORM-3103 allow nimbus to shutdown properly

[danny0405]

Github user danny0405 commented on the issue:

    https://github.com/apache/storm/pull/2718
  
    @agresch 
    Yes the 
    
[https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/StormTimer.java#L173](https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/StormTimer.java#L173)
    may throw an Interrupted Exception,
    but 
    `} catch (Throwable e) {
                        if 
(!(Utils.exceptionCauseIsInstanceOf(InterruptedException.class, e))
                            && 
!(Utils.exceptionCauseIsInstanceOf(ClosedByInterruptException.class, e))) {
                            this.onKill.uncaughtException(this, e);
                            this.setActive(false);
                        }
                    }`
    here it already make a decision that if the exception is not 
InterruptedException.class we shall register the uncaughtException, so in what 
situation you mean the deadlock will occur?



---