Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2711#discussion_r197605381
  
    --- Diff: 
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
 ---
    @@ -56,7 +57,7 @@ public static Tuple generateTestTuple(final String source,
             GeneralTopologyContext topologyContext = new 
GeneralTopologyContext(
                     builder.createTopology(),
                     new Config(),
    -                new HashMap<>(),
    +                new CustomIndexArray<String>(0,1),
    --- End diff --
    
    It is mostly for readability .. when reading this code its unclear what the 
deduced type will be without further checking the parameter types for the 
constructor. Happy to change if you prefer the other way.


---

Reply via email to