Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2733
  
    > The metrics-tests were doing assertions in a racy way. We can't guarantee 
that metrics fall in exact buckets, because the metrics are updated from the 
executor async loops, which aren't included in the threads covered by 
LocalCluster.waitForIdle. I've replaced the checks with validation that there 
are a certain number of metrics buckets, and that the metrics counters sum to 
the expected value.
    
    If it is not relevant to JDK 10, it would be better to split this PR up to 
have individual fix for flaky test. While someone wonders why we consider about 
Java 10 at all, the fix for flaky test is straightforward to be reviewed and 
merged sooner.


---

Reply via email to