Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2734#discussion_r197652064
  
    --- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
    @@ -196,6 +196,9 @@ private LocalCluster(Builder builder) throws Exception {
                 this.tmpDirs.add(nimbusTmp);
                 stormHomeBackup = System.getProperty(ConfigUtils.STORM_HOME);
                 TmpPath stormHome = new TmpPath();
    +            if (!stormHome.getFile().mkdirs()) {
    --- End diff --
    
    I might be going to too strict, but this looks like follow-up of STORM-3116 
(not relevant to Time) which would be better to have individual PR. The change 
is minor so no need to file a new issue. Just would like to avoid things 
getting mixed up in a commit.
    
    Will continue reviewing other change in PR.


---

Reply via email to