GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2746
STORM-3136: Fix flaky integration test, clean up that code to be moreâ¦
⦠readable
https://issues.apache.org/jira/browse/STORM-3136
* Deduplicated the test spouts and bolts a bit.
* Made sure all test spouts are waiting a reasonable amount of time between
emits. If the log rolls during the tests, the tests will fail. I think this is
the reason for the flakiness. It was fixed for some tests in an earlier PR, but
I missed that the spout code had so many duplicates.
* Added some documentation
* Replaced a bunch of Guava code with streams. Deleted unused code.
Simplified some classes, e.g. TimeDataWindow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2746
----
commit 739fc2ca48e7e2d91a0d11c3606b31e9483a33b3
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-06-28T19:17:38Z
STORM-3136: Fix flaky integration test, clean up that code to be more
readable
----
---
