Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2752#discussion_r200407111
  
    --- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
    @@ -59,6 +116,12 @@
             new Object[]{ "d", null }
         };
     
    +    /**
    +     * Prettigy uptime string.
    +     * @param val val.
    --- End diff --
    
    nit: val is a stringified integer.  Why it is not just an int?  but that is 
for a follow on JIRA not here.


---

Reply via email to