Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200456835
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh() {
_stormConf,
_spoutConfig,
id,
- deletedManagers.get(id.partition));
+ deletedManagers.get(new
TopicAndPartition(id.topic, id.partition)));
--- End diff --
Are you sure this lookup makes sense? The deletedManagers only contains
partitions that this task is no longer responsible for (curr - mine). That
partition shouldn't be able to also be in newPartitions (mine - curr). Won't
this always return null (unless you're hitting the bug that this PR is trying
to fix, namely that offsets are being copied from the PartitionManager for e.g.
topic1 to the PartitionManager for topic2)?
---
