Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2744#discussion_r201218268
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java ---
@@ -23,9 +23,13 @@ public Values() {
}
public Values(Object... vals) {
- super(vals.length);
- for (Object o : vals) {
- add(o);
+ super(vals != null ? vals.length : 0);
+ if (vals != null && vals.length != 0 ) {
--- End diff --
`vals.length != 0` should be removed in this condition, cause condition for
else statement would be `vals == null || vals.length == 0`, which
`Values(List())` goes into else statement and comes out of `Values(null)`
instead of no element.
---
