Github user priyank5485 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2760#discussion_r202213538
  
    --- Diff: 
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
 ---
    @@ -145,7 +148,8 @@ public static void main(String args[]) {
                     NewKafkaSpoutOffsetQuery newKafkaSpoutOffsetQuery =
                         new 
NewKafkaSpoutOffsetQuery(commandLine.getOptionValue(OPTION_TOPIC_LONG),
                                                      
commandLine.getOptionValue(OPTION_BOOTSTRAP_BROKERS_LONG),
    -                                                 
commandLine.getOptionValue(OPTION_GROUP_ID_LONG), securityProtocol);
    +                                                 
commandLine.getOptionValue(OPTION_GROUP_ID_LONG), securityProtocol,
    --- End diff --
    
    I suggest adding a check in the old spout if block and throw an error if 
this option provided with old spout.


---

Reply via email to