Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2762#discussion_r202342969
  
    --- Diff: 
storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java
 ---
    @@ -0,0 +1,35 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.  
The ASF licenses this file to you under the Apache License, Version
    + * 2.0 (the "License"); you may not use this file except in compliance 
with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software 
distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. See the License for the specific language governing permissions
    + * and limitations under the License.
    + */
    +
    +package org.apache.storm.messaging.netty;
    +
    +import java.io.IOException;
    +import java.util.Arrays;
    +import org.apache.storm.serialization.KryoValuesSerializer;
    +import org.apache.storm.shade.io.netty.buffer.ByteBuf;
    +import org.apache.storm.shade.io.netty.buffer.UnpooledByteBufAllocator;
    +import org.apache.storm.utils.Utils;
    +import org.junit.jupiter.api.Test;
    +
    +import static org.junit.jupiter.api.Assertions.*;
    +
    +class BackPressureStatusTest {
    +
    +    @Test
    +    void bufferTest() throws IOException {
    --- End diff --
    
    Actually I'll just delete it because there is no reason to keep it, 
especially because we don't verify the result in any way.


---

Reply via email to