Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202347946
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -118,16 +138,32 @@ public RelDataType getRowType(
@Override
public Statistic getStatistic() {
return stat != null ? stat : Statistics.of(rows.size(),
-
ImmutableList.<ImmutableBitSet>of());
+ ImmutableList.<ImmutableBitSet>of());
}
@Override
public Schema.TableType getJdbcTableType() {
return Schema.TableType.STREAM;
}
+
+ @Override
+ public boolean isRolledUp(String s) {
--- End diff --
Nit: `s` doesn't really say much as a variable name, can we replace it with
one that says what this string is? Same for the other methods here.
---
