GitHub user zd-project opened a pull request:

    https://github.com/apache/storm/pull/2764

     STORM-3147: Port ClusterSummary to StormMetricsRegistry

    This PR depends on #2763 
    The implementation is kind of ugly right now due to caching and 
synchronization in metrics update. I hope you can give out some advice in 
improvement. @revans2 @HeartSaVioR @srdo 
    
    @kishorvpatil I've listed out all metrics I think worth implementing from 
ClusterSummay in Measured enum. I'm not sure if there's value in 
SUPERVISOR_TOTAL_RESOURCE, TOPOLOGY_STATUS, and TOPOLOGY_SCHED_STATUS. I'd like 
to hear what you think.
    
    I have also discovered a potential bug of scheduler when working on this 
[STORM-3151](https://issues.apache.org/jira/browse/STORM-3151), can you help 
confirm it?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zd-project/storm STORM-3147

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2764
    
----
commit 802014c88a67ae5ef044c1f87889d976063eee71
Author: Zhengdai Hu <hu.zhengdai@...>
Date:   2018-07-12T16:31:00Z

    STORM-3150: Improve Gauge registration methods and refactored code

commit 4a8f63066dcede70a8df483383d6b2bcd616d299
Author: Zhengdai Hu <hu.zhengdai@...>
Date:   2018-07-13T19:22:20Z

    STORM-3147: Port ClusterSummary to StormMetricsRegistry

----


---

Reply via email to