Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Another thought on improvement of StormMetricsRegistry in general. We
should have something that works better with dependency as well. In the latest
commit to #2710 that addresses metric of exceptions from external shell
command, I have to register metrics from storm-client component to
StormMetricsRegistry, which is in storm-server. To bypass the dependency I
ended up declaring the meter in ShellUtil class but register it when launching
the supervisor. But this does prompt me to think about decoupling between
declaration and registration. Maybe we can have an Enum class that declares all
metrics (since all of them are singleton anyway); components can make reference
to them, and daemons can register/unregister them on demand when launching. It
also makes maintaining existing metrics a bit easier as now we have a place to
declare and organize all metrics.
@srdo @danny0405 @revans2
---
