Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203716797
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
}
});
+ //Be cautious using method reference instead of lambda.
subexpression preceding :: will be evaluated only upon evaluation
--- End diff --
Nit: Not sure about this comment, it's not really specific to this code,
but applies to any use of method references anywhere.
---
