Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205516198
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -89,13 +89,8 @@ public void prepare(Map<String, Object> conf) {
cachedSupervisors = new HashMap<>();
blacklistHost = new HashSet<>();
-
StormMetricsRegistry.registerGauge("nimbus:num-blacklisted-supervisor", new
Callable<Integer>() {
- @Override
- public Integer call() throws Exception {
- //nimbus:num-blacklisted-supervisor + none blacklisted
supervisor = nimbus:num-supervisors
- return blacklistHost.size();
- }
- });
+ //nimbus:num-blacklisted-supervisor + none blacklisted supervisor
= nimbus:num-supervisors
--- End diff --
nit: I have no idea what this comment means, so could we remove it? Unless
you understand it, then can we make it clearer?
---
