Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207586437 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. + * See the NOTICE file distributed with this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and limitations under the License. + */ + +package org.apache.storm.daemon.logviewer.testsupport; + +import org.mockito.Mockito; + +import java.io.File; + +public class MockRemovableFileBuilder extends MockFileBuilder { + @Override + public File build() { + File mockFile = super.build(); + Mockito.when(mockFile.delete()).thenReturn(true); --- End diff -- Should I still concern about this issue then? @revans2 @srdo
---