Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208745736
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId() + ":" + getPort();
}
+ public List<Object> toList() {
+ //For compatibility to call in Nimbus#mkAssignment
--- End diff --
I thought it looks cleaner to on Nimbus side. The legacy implementation
isn't pretty to start with. (a lot of List<Object> or List<Long>) If you want I
can file a Jira to improve `mkAssignment` in general, to eliminate them
altogether.
---
