Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209311727
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2826,21 +2882,27 @@ public void launchServer() throws Exception {
                     .parallelStream()
                     .mapToDouble(SupervisorResources::getTotalCpu)
                     .sum());
    -
    +            
StormMetricsRegistry.registerGauge("nimbus:longest-scheduling-time-ms", () -> {
    +                //We want to update longest scheduling time in real time 
in case scheduler get stuck
    +                // It's normal to see some very minor jiggling in value as 
race condition may happen
    --- End diff --
    
    Is the race still there given your reordering?


---

Reply via email to