Github user jacobtolar commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2806#discussion_r210671831
  
    --- Diff: pom.xml ---
    @@ -278,7 +278,7 @@
             <netty.version>4.1.25.Final</netty.version>
             <sysout-over-slf4j.version>1.0.2</sysout-over-slf4j.version>
             <log4j-over-slf4j.version>1.6.6</log4j-over-slf4j.version>
    -        <log4j.version>2.8.2</log4j.version>
    +        <log4j.version>2.11.0</log4j.version>
    --- End diff --
    
    Note: The update to log4j2-2.11.0 is not strictly necessary. 2.8.2 supports 
composite configuration. However, there was [a 
bug](https://issues.apache.org/jira/browse/LOG4J2-2123) in merging filters from 
child configurations that I got fixed in 2.11.0. If a child configuration added 
filters and there were none in the parent, the child filter would be ignored.
    
    I would like to add some filters in my topology, so, bumping the version to 
the one with the fix.


---

Reply via email to