Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210684974
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
<log4j-over-slf4j.version>1.6.6</log4j-over-slf4j.version>
<log4j.version>2.8.2</log4j.version>
<slf4j.version>1.7.21</slf4j.version>
- <metrics.version>3.1.0</metrics.version>
+ <metrics.version>3.2.6</metrics.version>
--- End diff --
Yes, sorry. The previous version didn't have the methods from this PR
https://github.com/dropwizard/metrics/pull/1023/files. We need them so we can
get `getOrAdd` behavior (either add the metric if not registered, or return the
existing metric) for metric registration that uses factory functions. Without
this ability, registering metrics (especially gauges) would be a pain, since
we'd have to be very careful only to register them once.
---
