Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2808#discussion_r213031503
  
    --- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
    @@ -1884,4 +1888,11 @@ public void setTopologyStrategy(String strategy) {
             this.put(Config.TOPOLOGY_SCHEDULER_STRATEGY, strategy);
         }
     
    +    public static String getBlobstoreHDFSPrincipal(Map conf) throws 
UnknownHostException {
    +        String principal = 
(String)conf.get(Config.BLOBSTORE_HDFS_PRINCIPAL);
    +        if (principal != null) {
    +            principal = principal.replace("HOSTNAME", 
Utils.localHostname());
    --- End diff --
    
    I agree _HOST is probably preferable, as it is less likely to result in a 
collision by accident, and it follows with what Hadoop is doing.


---

Reply via email to