Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2836#discussion_r217911059
  
    --- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java 
---
    @@ -0,0 +1,202 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.storm.stats;
    +
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +import org.apache.storm.generated.ClusterWorkerHeartbeat;
    +import org.apache.storm.generated.ExecutorInfo;
    +import org.apache.storm.generated.ExecutorStats;
    +import org.apache.storm.generated.GlobalStreamId;
    +import org.apache.storm.shade.com.google.common.collect.Lists;
    +import org.apache.storm.utils.Time;
    +
    +/**
    + * Stats calculations needed by storm client code.
    + */
    +public class ClientStatsUtil {
    +    public static final String SPOUT = "spout";
    +    public static final String BOLT = "bolt";
    +    static final String EXECUTOR_STATS = "executor-stats";
    +    static final String UPTIME = "uptime";
    +    public static final String TIME_SECS = "time-secs";
    +    public static final ToGlobalStreamIdTransformer TO_GSID = new 
ToGlobalStreamIdTransformer();
    +    public static final IdentityTransformer IDENTITY = new 
IdentityTransformer();
    +
    +    /**
    +     * Convert a List<Long> executor to java List<Integer>.
    +     */
    +    public static List<Integer> convertExecutor(List<Long> executor) {
    +        return Lists.newArrayList(executor.get(0).intValue(), 
executor.get(1).intValue());
    +    }
    +
    +    /**
    +     * Make and map of executors to empty stats.
    --- End diff --
    
    Nit: Couple of places saying "and" where it should say "a"/"an"


---

Reply via email to