Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2843#discussion_r218905963
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java
---
@@ -95,9 +95,12 @@ private static IStormClusterState
buildStateIfNeeded(Map<String, Object> conf, T
throw new IllegalArgumentException("Token is not valid, token
has expired.");
}
- PrivateWorkerKey key = keyCache.getUnchecked(deser);
- if (key == null) {
- throw new IllegalArgumentException("Token is not valid,
private key not found.");
+ PrivateWorkerKey key;
+ try {
+ key = keyCache.getUnchecked(deser);
+ } catch (CacheLoader.InvalidCacheLoadException e) {
+ //This happens when the cache has a null returned to it.
--- End diff --
not sure about this. If `getUnchecked(deser);` returns null, it will throw
an exception?
---
