Andrew, could you please initiate discussion thread instead? I feel the patch is no longer simple one to just get +1 and merge in, because everyone lose context on the patch.
Btw, as a contributor of multilang, the concept of supporting multiple languages are good, but not sure it can bring heavily optimized for major languages, mostly Python. One of example is supporting "subprocess timeout": it is actually incomplete because Interpreter languages work like the way, GIL. Note that the opinion is totally my own: as we move on 2.0 which has Streams API, I'd be happy if some Python engineers put their efforts to migrate it to python. The progress of Streams API is stuck for now, but it is still valid for at-least-once use cases and give much convenience while constructing topology. It should remedy the need to learn how to use for both things, Storm and other third parties. Someone might be concerned, but I think that's the way we need to go. -Jungtaek Lim (HeartSaVioR) 2018년 9월 27일 (목) 오전 8:53, P. Taylor Goetz <ptgo...@gmail.com>님이 작성: > Andrew, > > Thanks for bringing the private conversation back to the dev@ list so > everyone has more context. > > That being said, I’d encourage the use of the public mailing lists as much > as possible. Private conversations exclude the larger community from > participating in potentially fruitful discussions. > > Don’t get me wrong, I applaud you doing the right thing in bringing this > back to the community. I just wish it could have happened sooner. > > All good. We just do better next time. :) > > -Taylor > > > On Sep 26, 2018, at 5:58 PM, amontalenti <g...@git.apache.org> wrote: > > > > Github user amontalenti commented on the issue: > > > > https://github.com/apache/storm/pull/1136 > > > > Was chatting with @roshannaik and @dan-blanchard today, and this PR > came up. > > > > Someone on Storm team may benefit from taking a look at this as part > of the performance revisions being done for Storm 2.0. As mentioned in > [#428 in streamparse]( > https://github.com/Parsely/streamparse/issues/428#issuecomment-380135343) > -- the community project for running Python multi-lang topologies with > Storm -- getting this merged somewhere in the Storm codebase would open up > the possibility to switch serializer from Kryo & JSON to msgpack > throughout, which would speed up multi-lang use cases considerably. This PR > includes a pure Java implementation of a msgpack serializer, as well as > pointers to the right msgpack library in the Java community; it just needs > to be reviewed, tested, and merged. > > > > > > --- >
