Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2855#discussion_r222091724
--- Diff:
storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java ---
@@ -106,13 +106,13 @@ public void run() {
BufferedReader reader = new BufferedReader(new
InputStreamReader(stdin));
while ((str = reader.readLine()) != null) {
if (str.startsWith("ERROR")) {
+ LOG.warn("The healthcheck process {} exited with
code {}", script, process.exitValue());
return FAILED;
}
}
return SUCCESS;
--- End diff --
Should this not failed with `return FAILED_WITH_EXIT_CODE;` since the exit
code is not 0 ?
---
