Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2861#discussion_r223047510
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -66,10 +64,9 @@ private static Server mkHttpServer(StormMetricsRegistry
metricsRegistry, Map<Str
Server ret = null;
if (logviewerHttpPort != null && logviewerHttpPort >= 0) {
LOG.info("Starting Logviewer HTTP servers...");
- Integer headerBufferSize =
ObjectReader.getInt(conf.get(UI_HEADER_BUFFER_BYTES));
- String filterClass = (String)
(conf.get(DaemonConfig.UI_FILTER));
+ String filterClass = (String)
(conf.get(DaemonConfig.LOGVIEWER_FILTER));
@SuppressWarnings("unchecked")
- Map<String, String> filterParams = (Map<String, String>)
(conf.get(DaemonConfig.UI_FILTER_PARAMS));
+ Map<String, String> filterParams = (Map<String, String>)
(conf.get(DaemonConfig.LOGVIEWER_FILTER_PARAMS));
--- End diff --
Can we do something where this falls back to the UI_FILTER/UI_FILTER_PARAMS
if the LOGVIEWER ones are not set? That way we can maintain backwards
compatibility and still offer the option to separate the two?
---
