Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2871#discussion_r224550336
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
    @@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map<String, 
Object> conf, BlobStore bl
                         out.close();
                     }
                     isSuccess = true;
    +            } catch(FileNotFoundException fnf) {
    +                LOG.warn("FileNotFoundException", fnf);
    --- End diff --
    
    Okay I think I see it now.  On the local file output stream it can show up 
if the file/directory is deleted before we do the commit.  It would be good to 
document this, preferably in the LOG message, because FileNotFoundException is 
redundant, it is already going to log that and knowing why this is only a 
warning is preferable.


---

Reply via email to