Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2878#discussion_r225358947
  
    --- Diff: storm-core/src/jvm/org/apache/storm/command/KillTopology.java ---
    @@ -25,21 +25,49 @@
     
         public static void main(String[] args) throws Exception {
             Map<String, Object> cl = CLI.opt("w", "wait", null, CLI.AS_INT)
    +                                    .boolOpt("c", "continue-on-error")
    --- End diff --
    
    
    I suspect this conflicts with existing `-c` usage on 
https://github.com/apache/storm/blob/master/bin/storm.py#L1027 to specify 
general configuration parameters. I would use and `-i` `-ignore-errors` or 
something like that.


---

Reply via email to