Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233733766
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -692,11 +692,28 @@ public String toString() {
configuration.put(configKeyPrefix + "topics", getTopicsString());
configuration.put(configKeyPrefix + "groupid",
kafkaSpoutConfig.getConsumerGroupId());
- configuration.put(configKeyPrefix + "bootstrap.servers",
kafkaSpoutConfig.getKafkaProps().get("bootstrap.servers"));
- configuration.put(configKeyPrefix + "security.protocol",
kafkaSpoutConfig.getKafkaProps().get("security.protocol"));
+ for (Entry<String, Object> conf:
kafkaSpoutConfig.getKafkaProps().entrySet()) {
+ if (conf.getValue() != null &&
isPrimitiveOrWrapper(conf.getValue().getClass())) {
--- End diff --
nit: Might be better to leave a log message for dropped configuration keys
from here. Maybe DEBUG is fine since I guess they're only used for
storm-kafka-monitor.
---
