GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2934

    STORM-3310: Make JCQueueTest wait for consumer to read all queued ite…

    …ms before terminating
    
    https://issues.apache.org/jira/browse/STORM-3310
    
    I've only seen the test fail once, but it should be pretty easy to see that 
the test has a race. The tests all expect some messages to go through the 
queue, but the `run` method doesn't make sure the producers have actually 
produced anything, and even if they do, the consumer may be shut down before it 
can read the messages the producers put in the queue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3310

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2934
    
----
commit a84c879d3429afef946ab8e9c0d0cddf497e1c6d
Author: Stig Rohde Døssing <srdo@...>
Date:   2019-01-07T16:11:23Z

    STORM-3310: Make JCQueueTest wait for consumer to read all queued items 
before terminating

----


---

Reply via email to