Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2930#discussion_r245714702
--- Diff: bin/storm.py ---
@@ -132,13 +56,8 @@ def get_jars_full(adir):
elif os.path.exists(adir):
files = [adir]
- ret = []
- for f in files:
- if f.endswith(".jar"):
- ret.append(os.path.join(adir, f))
- return ret
+ return [os.path.join(adir, f) for f in files if f.endswith(".jar")]
-# If given path is a dir, make it a wildcard so the JVM will include all
JARs in the directory.
--- End diff --
Nit: Is this comment no longer relevant?
---
