Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2930
Thanks. It looks great. A few final things:
* When running `mvn clean install -DskipTests`, the tests for the script
are still run. Can we skip the executions if `skipTests` is true?
* Running the tests still generates a .pyc file in storm/bin, which ends up
in the distribution. I think we should either remove it after the tests run, or
explicitly exclude it from the storm-dist build.
* The help is sorted alphabetically, which is good. Can we do the same for
the positional arguments (e.g. jar, logviewer, kill)?
* I would still like us to describe the new dependency on `mock` in
DEVELOPER.md, as mentioned here
https://github.com/apache/storm/pull/2930#issuecomment-452016830. I think it is
ideal if people can blindly follow the setup guide and build Storm, having the
build fail because there are extra setup steps that aren't mentioned in the
guide could be demotivating to new people.
---
